security: consolidated crit+high remediation - #24
Merged
lua-stefan-kruger merged 2 commits intoJul 24, 2026
Conversation
Adds durable major-scoped npm overrides + direct-dep range bumps so the already-patched transitive tree cannot regress on future installs. Closes (patched version present in tree, override-pinned within major): - CRITICAL protobufjs GHSA (7.6.5), CRITICAL websocket-driver <0.7.5 (absent, pinned >=0.7.5) - HIGH axios (1.16.0+), undici (6.27.0), ws (8.21.0), form-data (4.0.6), @grpc/grpc-js (1.9.16), react-router (7.15.0), picomatch (4.0.4), socket.io-parser (4.2.6), tar (7.5.16), minimatch (10.2.3), @isaacs/brace-expansion (5.0.1), protobufjs (7.6.x) - plus med/low: js-yaml, uuid, follow-redirects, @protobufjs/utf8, mdast-util-to-hast Overrides are major-scoped (pkg@major) with >=floor <next-major ranges to avoid downgrade/major-forcing regressions. Lockfile-verified: no downgrades. Deferred (MAJOR-only, breaking lua-cli@3.7.0 downgrade; no open Dependabot alert): @opentelemetry/* cluster, @livekit/agents, sharp <0.35.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8549182. Configure here.
Bugbot flagged that package.json overrides were not reflected in the package-lock.json root package. Mirror the major-scoped overrides into packages[""].overrides so the lockfile is self-consistent with the manifest. npm ci --dry-run passes; no version downgrades (tree already patched).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Consolidated remediation of CRITICAL + HIGH Dependabot alerts for
lua-shopping-assistant(the only alerted package manifest in this repo; npm).The transitive tree was already refreshed to patched versions in prior lockfile commits (#21, lua-cli@3.21.0 refresh) but package.json carried no overrides, leaving the fix fragile. This PR makes it durable by adding major-scoped npm overrides (
pkg@majorkeys,>=floor <next-majorranges) plus direct-dep range bumps. Lockfile re-resolved with no downgrades and no major-forcing (verified per-package).Criticals closed (→ 0 remaining in scope)
>=7.6.5 <8(tree: 7.6.5)<0.7.5— not present in tree; pinned>=0.7.5 <0.8to prevent reintroductionHighs closed (within-major, bump/override-fixable)
axios (
^1.16.0, tree 1.18.1), undici (>=6.27.0), ws (>=8.21.0), form-data (>=4.0.6), @grpc/grpc-js (>=1.9.16), react-router (>=7.15.0), picomatch (>=4.0.4), socket.io-parser (>=4.2.6), tar (>=7.5.16), minimatch (>=10.2.3), @isaacs/brace-expansion (>=5.0.1), protobufjs (7.6.x high chain).Also clears in-scope mediums/lows for free: js-yaml (
^4.2.0), uuid (^13.0.1), follow-redirects, @protobufjs/utf8, mdast-util-to-hast.npm auditconfirms every Dependabot-target package is clean in the resolved tree.Deferred — MAJOR-only / breaking (NOT in this PR, no open Dependabot alert)
These are only fixable via a breaking
lua-cli@3.7.0downgrade and are out of within-major scope:<0.35— high (libvips CVEs). Note: sharp 0.35 changed its TS export; a future bump must fix anyimport * as sharpsites.Verification (no CI configured in this repo)
npm install/ lockfile re-resolve: clean, idempotent, no downgrades.tsc: 50 pre-existing app-source type errors inEcommerceTool.ts/dist-v2— identical count on master baseline; this PR introduces none. Onlypackage.json+package-lock.jsonchanged.Do not squash-merge blindly — leave for admin merge. Merging closes the crit+high Dependabot alerts listed above.
Note
Medium Risk
Touches many transitive networking, gRPC, and parsing libraries via overrides; within-major only but still affects the full install tree at runtime.
Overview
Hardens lua-shopping-assistant dependency resolution against known CRITICAL/HIGH npm advisories by bumping a few direct ranges and adding major-scoped
overridesso transitive packages stay on patched floors.Direct dependency ranges move to
axios^1.16.0,js-yaml^4.2.0, anduuid^13.0.1;package-lock.jsonis re-resolved to match. New overrides pin minimum safe versions for transitives includingprotobufjs@7,websocket-driver@0,undici@6,ws@8,form-data@4,@grpc/grpc-js@1,react-router@7,picomatch@4,socket.io-parser@4,tar@7,minimatch@10, and@isaacs/brace-expansion@5—all within the same major lines to avoid forced breaking upgrades.Reviewed by Cursor Bugbot for commit 2eee0df. Bugbot is set up for automated code reviews on this repo. Configure here.