fix(tools): unpack tar.xz release assets instead of running them - #38
Merged
Conversation
1axen/blink ships .tar.xz for macos and linux. Nothing sniffed xz, so it fell through to the branch that means "these bytes are the executable" and the compressed archive got written to the binary's path. Every run after that said cannot execute binary file, which points nowhere near the real problem. Windows was fine because that one asset is a .tar.gz. xz is decompressed now. The crate is pure rust rather than the liblzma bindings so the release matrix does not grow a C build step for the sake of one archive format per install. Everything else compressed that lpm has no decompressor for is sniffed too and says so instead of falling into the same trap. That is zstd, bzip2, 7z and rar. What comes out of a decompressor is checked for a tar header before being treated as one, so a bare .xz or .gz holding just the binary works as well as a .tar.xz holding a directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1axen/blink ships .tar.xz for macos and linux. Nothing sniffed xz, so it fell through to the branch that means "these bytes are the executable" and the compressed archive got written to the binary's path. Every run after that said cannot execute binary file, which points nowhere near the real problem. Windows was fine because that one asset is a .tar.gz.
xz is decompressed now. The crate is pure rust rather than the liblzma bindings so the release matrix does not grow a C build step for the sake of one archive format per install.
Everything else compressed that lpm has no decompressor for is sniffed too and says so instead of falling into the same trap. That is zstd, bzip2, 7z and rar.
What comes out of a decompressor is checked for a tar header before being treated as one, so a bare .xz or .gz holding just the binary works as well as a .tar.xz holding a directory.