fix(auth): OAuth callback URI and review hardening#14
Merged
MarcelRoozekrans merged 2 commits intomainfrom Mar 22, 2026
Merged
Conversation
The callback URI was vscode://lucent-code/oauth-callback but VS Code URI handlers require the publisher.extensionId format: vscode://lucentcode.lucent-code/oauth-callback Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix stale comment referencing old OAuth callback URI - Add .catch() on handleOAuthCallback to prevent unhandled rejection - Use 'unknown' type in .catch() handlers (not 'Error') for correctness Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lucent-code | 875aa71 | Commit Preview URL Branch Preview URL |
Mar 22 2026, 07:10 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vscode://lucent-code/tovscode://lucentcode.lucent-code/(must matchpublisher.extensionId).catch()onhandleOAuthCallbackto prevent unhandled promise rejectionunknowntype in.catch()handlers for correctnessTest plan
🤖 Generated with Claude Code