Skip to content

fix(auth): OAuth callback URI and review hardening #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcelRoozekrans merged 2 commits into from
Mar 22, 2026
Merged

fix(auth): OAuth callback URI and review hardening #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ec8b19
fix(auth): use correct publisher.extensionId in OAuth callback URI
MarcelRoozekrans Mar 22, 2026
875aa71
fix: address code review findings
MarcelRoozekrans Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class AuthManager {
this.pendingOAuth = { state, codeVerifier };

const callbackUri = await vscode.env.asExternalUri(
vscode.Uri.parse('vscode://lucent-code/oauth-callback')
vscode.Uri.parse('vscode://lucentcode.lucent-code/oauth-callback')
);

const params = new URLSearchParams({
Expand Down
20 changes: 11 additions & 9 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ export async function activate(context: vscode.ExtensionContext) {
}

// Non-critical: don't let skill loading crash activation
await loadSkills().catch((e: Error) =>
console.warn('[Lucent Code] Failed to load skills:', e.message)
await loadSkills().catch((e: unknown) =>
console.warn('[Lucent Code] Failed to load skills:', e instanceof Error ? e.message : String(e))
);

// Register chat webview
Expand All @@ -108,15 +108,15 @@ export async function activate(context: vscode.ExtensionContext) {
}

// Non-critical: don't let MCP connection crash activation
await connectMcpServers().catch((e: Error) =>
console.warn('[Lucent Code] Failed to connect MCP servers:', e.message)
await connectMcpServers().catch((e: unknown) =>
console.warn('[Lucent Code] Failed to connect MCP servers:', e instanceof Error ? e.message : String(e))
);

if (workspaceRoot) {
indexer.start(workspaceRoot)
.then(() => { indexerStatusBar.text = '$(database) Indexed'; })
.catch((e: Error) => {
console.error('[Indexer] Failed to start:', e.message);
console.error('[Indexer] Failed to start:', e instanceof Error ? e.message : String(e));
indexerStatusBar.text = '$(warning) Index failed';
});
}
Expand Down Expand Up @@ -149,8 +149,8 @@ export async function activate(context: vscode.ExtensionContext) {

// Set up instructions loader
const instructionsLoader = new InstructionsLoader();
await instructionsLoader.load().catch((e: Error) =>
console.warn('[Lucent Code] Failed to load instructions:', e.message)
await instructionsLoader.load().catch((e: unknown) =>
console.warn('[Lucent Code] Failed to load instructions:', e instanceof Error ? e.message : String(e))
);
instructionsLoader.watch();
contextBuilder.setInstructionsLoader(instructionsLoader);
Expand Down Expand Up @@ -331,12 +331,14 @@ export async function activate(context: vscode.ExtensionContext) {
})
);

// Register URI handler for OAuth callback (vscode://lucent-code/oauth-callback)
// Register URI handler for OAuth callback (vscode://lucentcode.lucent-code/oauth-callback)
context.subscriptions.push(
vscode.window.registerUriHandler({
handleUri(uri: vscode.Uri) {
if (uri.path === '/oauth-callback') {
auth.handleOAuthCallback(uri);
auth.handleOAuthCallback(uri).catch((e: unknown) =>
console.error('[Lucent Code] OAuth callback failed:', e instanceof Error ? e.message : String(e))
);
}
},
})
Expand Down
Loading