Skip to content

Improved permission suggestions#321

Closed
BrainStone wants to merge 2 commits into
LuckPerms:masterfrom
BrainStone:feature/better-suggestions
Closed

Improved permission suggestions#321
BrainStone wants to merge 2 commits into
LuckPerms:masterfrom
BrainStone:feature/better-suggestions

Conversation

@BrainStone
Copy link
Copy Markdown
Contributor

So here we are. The suggestions should be much better now.

I sadly couldn't find an option to make so pressing tab added the current selected choice to the search query or that a button appears. If anyone know how to do that, feel free to either let me know so I can add it or add it themselves.

This change goes towards #316

Technically closes that issue but doesn't take care of the other optional things I mentioned.

- Also ran the linter over the file. Those are the ranom changes everywhere in the file
- Making the linter happier as well
@BrainStone
Copy link
Copy Markdown
Contributor Author

BrainStone commented Sep 13, 2020

Can be tested live here: https://editor.project-creative.net/editor/
And a decent editor session for testing: https://editor.project-creative.net/editor/RzVOkM1DXH

@lucko
Copy link
Copy Markdown
Member

lucko commented Sep 13, 2020

I personally quite liked being able to browse through all available nodes... losing that functionality is a step in the wrong direction imo.

Perhaps another button next to "Press enter to select" which allows that node to be expanded?

In my opinion that needs to be solved before this can be merged.

@lucko
Copy link
Copy Markdown
Member

lucko commented Sep 13, 2020

And actually - the "press enter to select" is useless for the nodes which aren't leafs - since (unless you're using Sponge wildcards) they are not going to work as permissions.

@BrainStone
Copy link
Copy Markdown
Contributor Author

The goal here was to declutter the suggestions because it can become too much too quickly.
So the idea was to mimic the ingame completion.

After having used it like that i agree that not being able to select the partial text node makes it almost worse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants