Improved permission suggestions#321
Closed
BrainStone wants to merge 2 commits into
Closed
Conversation
- Also ran the linter over the file. Those are the ranom changes everywhere in the file
- Making the linter happier as well
Contributor
Author
|
Can be tested live here: https://editor.project-creative.net/editor/ |
Member
Member
|
And actually - the "press enter to select" is useless for the nodes which aren't leafs - since (unless you're using Sponge wildcards) they are not going to work as permissions. |
Contributor
Author
|
The goal here was to declutter the suggestions because it can become too much too quickly. After having used it like that i agree that not being able to select the partial text node makes it almost worse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

So here we are. The suggestions should be much better now.
I sadly couldn't find an option to make so pressing tab added the current selected choice to the search query or that a button appears. If anyone know how to do that, feel free to either let me know so I can add it or add it themselves.
This change goes towards #316
Technically closes that issue but doesn't take care of the other optional things I mentioned.