fix(deps): bump brace-expansion to 5.0.8 (CVE-2026-14257)#117
Merged
Conversation
npm audit flags brace-expansion <= 5.0.7 as a high-severity DoS (GHSA-mh99-v99m-4gvg). The hoisted 5.0.7 instance was only pinned by the lockfile — the declaring range (minimatch@10 -> ^5.0.2) already permits 5.0.8, so refreshing the lockfile is enough. No package.json change and no overrides entry are needed, and the entry stays dev-only. The two remaining brace-expansion@2.1.2 instances (webdav -> minimatch, @vue/language-core -> minimatch) stay flagged: 2.1.2 is the latest maintenance-v2 release and upstream shipped no 2.x backport. Overriding them to 5.x is not viable, since v5 exports { expand } instead of a default function and would break minimatch@3 consumers. Also syncs the lockfile's version field to 1.41.2, which had drifted from package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #116, which addressed the same advisory but in a way that would have made things worse.
What
npm auditflagsbrace-expansion <= 5.0.7as a high-severity DoS (unbounded expansion → OOM crash), GHSA-mh99-v99m-4gvg / CVE-2026-14257.The hoisted
5.0.7instance was only pinned by the lockfile. The declaring ranges already permit5.0.8, sonpm update brace-expansionis the whole fix — nopackage.jsonchange and nooverridesentry needed, and the entry staysdev: true.The lockfile's
versionfield also drifted (1.40.0vs.1.41.2inpackage.json); this syncs it.Coverage
Every
brace-expansionin the tree comes in viaminimatch:eslint@10.7.0→minimatch@10.2.5@nextcloud/vite-config→vite-plugin-dts→@microsoft/api-extractor→minimatch@10.2.3@nextcloud/dialogs→webdav→minimatch@9.0.9@nextcloud/vite-config→vite-plugin-dts→@vue/language-core→minimatch@9.0.9npm auditreports "No fix available" for the two2.1.2paths:2.1.2is the latestmaintenance-v2release and upstream shipped no 2.x backport.Overriding them to 5.x is not viable.
minimatch@9does__importDefault(require("brace-expansion"))and calls the default export; v2 is a function, whereas v5 is ESM-first and exports a{ expand, … }object — the call would throw at runtime.Impact of the remainder is low regardless:
brace-expansionis not imported anywhere insrc/, never reaches the Vite bundle, and the input tominimatchhere is glob patterns from build tooling, not user data. Left for upstream.Verification
npm run buildpassesnpm auditno longer listsnode_modules/brace-expansion(3 flagged paths → 2)registry.npmjs.orgforbrace-expansion@5.0.8package-lock.jsononly, 6 lines