fix(android): reposition Google watermark with edge insets#55
Merged
Conversation
setPadding() on Android Google Maps SDK does not reposition the Google watermark/logo. Use translationY/X to manually adjust it. Animate the translation when called via command with duration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android Google Maps SDK's
setPadding()does not reposition the Google watermark/logo — it stays pinned to the bottom-left and gets clipped when bottom padding is applied. This PR manually adjusts the watermark position usingtranslationY/translationXto match the current edge insets, with animation support when called via command with duration.Also includes an iOS fix to track raw edge insets separately from
layoutMargins(which includes safe area insets wheninsetsLayoutMarginsFromSafeAreais enabled), preventing the animation tick from drifting.Type of Change
Test Plan
edgeInsetswith bottom padding and verify Google watermark is visible above the padded areasetEdgeInsetscommand with duration and verify watermark animates smoothlyinsetsLayoutMarginsFromSafeAreaenabledChecklist