ci: drop xcframework distribution from the release pipeline#97
Merged
Conversation
The rc-build-xcframework job zipped loose release .swiftmodule files into a directory named .xcframework — not a valid xcframework (no Info.plist, no binary, no device slices), so the 5 assets it attached to each release could not be linked. Building a real, importable xcframework would require library evolution (BUILD_LIBRARY_FOR_DISTRIBUTION=YES), which DataStructure/IdentifiedArray rejects: its @inlinable inits initialize stored properties directly, which resilient mode forbids. Reworking that would degrade IdentifiedArray's inlining for binaries nobody consumes (integration is SwiftPM source) and contradicts the swift-library standard, whose canonical release pipeline ships no xcframeworks. Remove the job, its needs entry in rc-notify-status, and the artifact download/attach from create-release. Releases now publish notes only — source-only distribution, matching Hourglass and the standard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the
rc-build-xcframeworkjob and stop attaching xcframework assets to releases. FP becomes source-only, matching Hourglass and theswift-librarystandard.Why
The job zipped loose release
.swiftmodulefiles into a directory named.xcframework— noInfo.plist, no binary, no device slices — so the 5 assets attached to each release (e.g.v2.0.0) are not valid xcframeworks and cannot be linked.Building a real, importable xcframework requires library evolution (
BUILD_LIBRARY_FOR_DISTRIBUTION=YES), whichDataStructure/IdentifiedArrayrejects: its@inlinableinits initialize stored properties directly, forbidden under resilient mode. Reworking that would degradeIdentifiedArray's inlining (its whole purpose) for binaries nobody consumes — everything integrates via SwiftPM source — and theswift-librarycanonical release pipeline ships no xcframeworks anyway.Changes
rc-build-xcframeworkjob.rc-notify-statusneeds; simplify that job's notice.create-release: remove the artifact download +List Artifactssteps and theartifacts/*/*.zipargument; fix the install note to a normal SPM snippet. Releases now publish notes only.Not in scope
The 5 stale fake assets already on the existing
v2.0.0GitHub Release (can be deleted separately withgh release delete-asset).🤖 Generated with Claude Code