refactor(web): remove dead code biome flags in ui#95
Open
lukaso-bot wants to merge 1 commit into
Open
Conversation
PartialResult computed repoDisplay + sha but never rendered them (the card uses result.urls.commit directly for both the CLI box and the View button); layout.tsx imported hono/html's `html` helper but only `raw` is used (the `<html>` tag is JSX, not the import). biome flags all three as noUnusedVariables warnings — tolerated by the gate (warnings, not errors), so they had slipped every cycle, but they train the lint to be ignored. Pure dead-code removal; render output is byte-identical. Co-Authored-By: Claude <noreply@anthropic.com>
lukaso-bot
commented
Jul 9, 2026
lukaso-bot
left a comment
lukaso-bot
left a comment
Collaborator
Author
There was a problem hiding this comment.
In-house adversarial review (Copilot perpetually quota-blocked on this repo → in-house pass per review-policy). Verified each removal against the source — all genuinely dead, render-output-identical:
- layout.tsx
htmlimport: the onlyhtmltokens in the file are the import line and the<html lang="en">JSX tag (line 28 / 64) — that's JSX, not thehono/htmlhtmltemplate helper. Nohtml\`` /html(` anywhere. Safe to drop. - result-card.tsx
repoDisplay+sha: neither is referenced anywhere in thePartialResultbody. The partial card is CTA-focused — it usesresult.urls.commitdirectly for both the CLI-command box and the "View commit on …" button. Leftover scaffolding, not a missing render.
Pure removal; byte-identical output. Cleared.
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes three
noUnusedVariables/noUnusedImportswarnings biome flags inpackages/web/src/ui, but the gate tolerates (warnings, not errors) — so they had slipped every cycle:result-card.tsx—PartialResultcomputedrepoDisplayandshabut never rendered them. The "taking longer" card usesresult.urls.commitdirectly for both the CLI command box and the "View commit on …" button.layout.tsximportedhono/html'shtmlhelper, but onlyrawis used. The<html lang="en">is a JSX tag, not the imported function.Why
"A warning that lives forever trains everyone to ignore lint." These sat on the partial-result surface (the
partial ≠ not-yet-releasedinvariant), so worth clearing on a quiet cycle.Is this a latent gap?
Investigated before deleting. The released card renders
repoDisplay+shortShain its.answer-metarow, andNotYetReleasedshows the short sha inline — but the partial card is intentionally CTA-focused (CLI command + View button, both already carry the full commit URL). So these are leftover scaffolding, not a missing feature. Rendering new UI here would be a design call needingDESIGN.md, out of scope for a lint cleanup.Verification
Pure dead-code removal; render output is byte-identical.
pnpm --filter @released/web exec biome check src→ 0 warnings (was 3)pnpm -r typecheck→ green (all 4 packages)pnpm -r test→ 534 passed / 0 failed (core 256, cli 45, web-og 13, web 220)./scripts/validate.sh→ exit 0🤖 Generated with Claude Code