This repository was archived by the owner on Jul 6, 2026. It is now read-only.
Cosmos SDK v0.45.7 with IBC V3 - #11
Merged
Merged
Conversation
… framework. Got rid of homemade simapp
lebascou
reviewed
Aug 26, 2022
lebascou
left a comment
Contributor
There was a problem hiding this comment.
LGTM for now, to be tested thoroughly.
Please check and comment if needed the CodeQL warnings.
Segfaultd
marked this pull request as ready for review
August 26, 2022 13:03
Ricardo-Remy
pushed a commit
that referenced
this pull request
May 30, 2023
* Fix validator split implementation and add related unittest * Fix wrong test usage --------- Co-authored-by: Fabrice Bascoulergue <lebascou@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a few major changes:
The ICS 27 integration has been realized using the official documentation available here https://github.com/cosmos/ibc-go/blob/main/docs/migrations/v2-to-v3.md
The upgrade enables both host & controller modes, and it registers a few message to be authorized through ICA, including the custom beam ones.