Skip to content
This repository was archived by the owner on Jul 6, 2026. It is now read-only.

Cosmos SDK v0.45.7 with IBC V3 - #11

Merged
Segfaultd merged 3 commits into
masterfrom
improvement/ibc_v3_upgrade
Aug 26, 2022
Merged

Cosmos SDK v0.45.7 with IBC V3#11
Segfaultd merged 3 commits into
masterfrom
improvement/ibc_v3_upgrade

Conversation

@Segfaultd

@Segfaultd Segfaultd commented Aug 25, 2022

Copy link
Copy Markdown
Member

Description

This pull request introduces a few major changes:

  • First, we bump used versions of the SDK to the latest non-breaking one, v0.45.7
  • Second, we introduce a cleaner structure for the app folder. Now keepers have their own file, and are initialized in separate functions all getting called in the root app initialize function
  • Third, we get rid of the simapp. Used as a simulation application for local testing purposes, it was in fact introducing a higher level of complexity than required, with possibles desync due to the fact that every change on the main app has to be copied out to the simapp. Every testing suite has been modified to reflect that change.
  • Fourth, we bump IBC used version from v2 to v3. This also introduces ICS 27, a.k.a Interchain Accounts.

The ICS 27 integration has been realized using the official documentation available here https://github.com/cosmos/ibc-go/blob/main/docs/migrations/v2-to-v3.md

The upgrade enables both host & controller modes, and it registers a few message to be authorized through ICA, including the custom beam ones.

@Segfaultd
Segfaultd requested a review from lebascou August 25, 2022 15:37

@lebascou lebascou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now, to be tested thoroughly.
Please check and comment if needed the CodeQL warnings.

@Segfaultd
Segfaultd marked this pull request as ready for review August 26, 2022 13:03
@Segfaultd
Segfaultd merged commit 81d582b into master Aug 26, 2022
@Segfaultd
Segfaultd deleted the improvement/ibc_v3_upgrade branch August 26, 2022 13:04
Ricardo-Remy pushed a commit that referenced this pull request May 30, 2023
* Fix validator split implementation and add related unittest

* Fix wrong test usage

---------

Co-authored-by: Fabrice Bascoulergue <lebascou@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants