This repository was archived by the owner on Jul 6, 2026. It is now read-only.
[LUM-409] Implement Cosmos v0.46.0 - #14
Merged
Merged
Conversation
- Dependencies bump - StoreTypes usage - IBCFee module implementation - Centralized testing chain init - Default params and validator set - Removed legacy rest endpoints - Backported legacy proposal system
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Segfaultd
marked this pull request as ready for review
October 25, 2022 10:18
lebascou
reviewed
Oct 26, 2022
lebascou
left a comment
lebascou
left a comment
Contributor
There was a problem hiding this comment.
Implementation LGTM, we need to thoroughly test the following now:
- Keplr: RPC behaviour since it's been heavily deprecated and edited
- IBC: All features in a production like environment
lebascou
suggested changes
Nov 7, 2022
lebascou
approved these changes
Nov 7, 2022
Ricardo-Remy
added a commit
that referenced
this pull request
May 30, 2023
[LUM-591] - MsgServer -> clean up and split tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
This PR introduces a few changes related to the used Cosmos SDK version, but also the used IBC version.
It bumps the SDK to 0.46.0, which is a major upgrade with breaking changes:
It also bumps IBC-Go to v5.
Upgrade guides
https://github.com/cosmos/ibc-go/blob/main/docs/migrations/v3-to-v4.md
https://github.com/cosmos/ibc-go/blob/main/docs/migrations/v4-to-v5.md
Testing
The unit tests have been patched to compile but no logic was touched.
Considering the deep changes we introduce, we must carefully test this on a dedicated network before sending to mainnet.