Skip to content

feat(check): support specifying directories#1663

Merged
mrcjkb merged 3 commits into
lumen-oss:mainfrom
Isvane:feat/specify-dir-check
Jul 12, 2026
Merged

feat(check): support specifying directories#1663
mrcjkb merged 3 commits into
lumen-oss:mainfrom
Isvane:feat/specify-dir-check

Conversation

@Isvane

@Isvane Isvane commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Description

Close #1407

Add support for specifying dir for lx check.
Happy to receive any feedback about the implementation 🙏

Changes:

  • Modified argument parsing for the check command to accept path target
  • Reused PathTarget and classify_path

@Isvane
Isvane requested review from mrcjkb and vhyrro as code owners July 11, 2026 13:41
Comment thread lux-cli/src/check.rs
Comment thread lux-cli/src/check.rs
@Isvane Isvane closed this Jul 12, 2026
@Isvane
Isvane deleted the feat/specify-dir-check branch July 12, 2026 17:27
@Isvane
Isvane restored the feat/specify-dir-check branch July 12, 2026 17:29
@Isvane

Isvane commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

man... accidentally pressed delete 🗿

@Isvane Isvane reopened this Jul 12, 2026
@Isvane
Isvane requested a review from mrcjkb July 12, 2026 17:51
@Isvane

Isvane commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

Hmm... I just realized fmt already use -p for package. Probably should be changed to short = k instead for package if we want to make the -p consistent for path? 🤔

@mrcjkb

mrcjkb commented Jul 12, 2026

Copy link
Copy Markdown
Member

Hmm... I just realized fmt already use -p for package. Probably should be changed to short = k instead for package if we want to make the -p consistent for path? 🤔

Good call! Let's get rid of the short flag for now.

@mrcjkb

mrcjkb commented Jul 12, 2026

Copy link
Copy Markdown
Member

@Isvane

Isvane commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

short flag removed 🫡

Comment thread lux-cli/src/check.rs Outdated
@Isvane
Isvane force-pushed the feat/specify-dir-check branch from 18d1417 to 32961be Compare July 12, 2026 19:06
@Isvane
Isvane requested a review from mrcjkb July 12, 2026 19:07
@mrcjkb
mrcjkb merged commit ada97db into lumen-oss:main Jul 12, 2026
12 checks passed
@github-actions github-actions Bot mentioned this pull request Jul 12, 2026
@Isvane
Isvane deleted the feat/specify-dir-check branch July 13, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support for specifying directories for lx check

2 participants