Clarify Scope struct serves both JWT and API key authentication#149
Merged
jeroenrinzema merged 2 commits intofeat/145from Feb 5, 2026
Merged
Clarify Scope struct serves both JWT and API key authentication#149jeroenrinzema merged 2 commits intofeat/145from
jeroenrinzema merged 2 commits intofeat/145from
Conversation
Co-authored-by: jeroenrinzema <3440116+jeroenrinzema@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update to address feedback on exposing HTTP services
Clarify Scope struct serves both JWT and API key authentication
Feb 5, 2026
jeroenrinzema
added a commit
that referenced
this pull request
Feb 5, 2026
* feat: expose http services on a single port and merged specs, closes #145 * Update internal/http/controllers/v1/http.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Clarify Scope struct serves both JWT and API key authentication (#149) * Update Scope comment to clarify dual authentication purpose Co-authored-by: jeroenrinzema <3440116+jeroenrinzema@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jeroenrinzema <3440116+jeroenrinzema@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Scopestruct ininternal/claim/rbac/rbac.gois used for both management API (JWT tokens) and client API (API keys) authentication, but the comment only mentioned "user" context.Changes
Scopestruct comment to explicitly document dual authentication purpose:The struct is populated by
WithJWT()for admin users andWithKey()for API keys ininternal/http/auth/auth.go.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.