fix(input): hardcoded width restrictions to fix horizontal scroll - #5
Merged
lupodevelop merged 2 commits intoJun 5, 2026
Merged
Conversation
… horizontal scroll
Owner
|
Can you fix the formatting so I can proceed with the merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
What does this PR do?
Fixes a visual bug in
etui/src/etui/widgets/input.gleamwhere the input text truncation and cursor tracking arbitrarily subtracted 2 columns from the allocatedarea.size.width, causing the cursor to jump prematurely.Changes:
- 2margin withw_avail = int.max(1, area.size.width).w_availevenly toview_startcalculation, text truncation, and padding.Tests
Video
Before
Gravacao.de.Tela.2026-06-04.004628.mp4
After
Gravacao.de.Tela.2026-06-04.004304.mp4