ci: pass gated=false to enable rubygems publish#8
Merged
Conversation
The metanorma/ci rubygems-release.yml computes SHOULD_PUBLISH:
github.event_name == 'workflow_dispatch' &&
(inputs.gated == false || secrets.pat_token == '')
Without 'gated: false' AND with pat_token set, the condition
evaluates to false and the workflow bumps + tags but never
publishes to rubygems. The previous run (ea_release7, success)
created tag v0.1.1 but did not push the gem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
SHOULD_PUBLISHcondition inmetanorma/ci'srubygems-release.ymlis:Without
gated: falseAND withpat_tokenset (we pass${{ secrets.GITHUB_TOKEN }}), the condition is false. The previous release run (ea_release7) marked itself "success" but only bumped the version and pushed the v0.1.1 tag — it never pushed the gem to rubygems.Fix
Add
gated: falseto thewith:block soSHOULD_PUBLISHevaluates true forworkflow_dispatchon this repo.