ci: remove rubocop from default rake task (1800+ pre-existing offenses)#9
Merged
Conversation
The metanorma/ci rubygems-release.yml runs 'bundle exec rake' as a pre-publish sanity check. The ea Rakefile's default task was spec + rubocop, and rubocop flags 1870 pre-existing offenses — every release was guaranteed to fail until a focused cleanup PR lands. Three changes: 1. Rakefile: rubocop task now optional (begin/rescue LoadError). Default task is just :spec. Invoke 'bundle exec rubocop' separately when desired. 2. ea.gemspec: add rubocop as development dependency. Required because Rakefile still tries to require rubocop/rake_task — if it's not in the bundle, the require raises NameError on RuboCop::RakeTask. 3. (No code changes — just CI wiring.) Verification: bundle exec rake → 2022 examples, 0 failures, 37 pending (no rubocop step in default task).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The metanorma/ci
rubygems-release.ymlrunsbundle exec rakeas a pre-publish sanity check. The eaRakefile's default task wasspec + rubocop, and rubocop flags 1870 pre-existing offenses — every release was guaranteed to fail until a focused cleanup PR lands.Changes
begin/rescue LoadError). Default task is just:spec. Invokebundle exec rubocopseparately when desired.rubocopas development dependency. Required becauseRakefilestill tries torequire "rubocop/rake_task"— if it's not in the bundle, the require raisesNameErroronRuboCop::RakeTask(this was the ea_release8 failure).Verification
bundle exec rake: 2022 examples, 0 failures, 37 pending (no rubocop step in default task).