Merged
Conversation
Member
zhaozg
commented
Oct 13, 2020
zhaozg
commented
- update libuv to v1.40.0
- update LuaJIT
* update libuv to v1.40.0 * update LuaJIT
Member
|
Missing bindings: |
Member
Author
Done |
Member
Author
|
I report a bug to libuv at libuv/libuv#3020 |
The correct check should be == 0 but that's not always true because the value is uninitialized so just skip that assert for now instead of suppression the Valgrind error.
Member
|
Created a pull request to your branch with some improvements: zhaozg#3 |
Fixup timer:get_due_in() tests
squeek502
approved these changes
Oct 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.