[WRONG BRANCH] test(ci): pin Windows CI step to run bun test --isolate tests with shard - #13
[WRONG BRANCH] test(ci): pin Windows CI step to run bun test --isolate tests with shard#13luvs01 wants to merge 1 commit into
bun test --isolate tests with shard#13Conversation
|
Warning Review limit reached
Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
github-actions
Bot
changed the title
bun test --isolate tests with shardbun test --isolate tests with shard
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa28493365
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| expect(winSteps.some(step => step.run?.includes("bun test --isolate tests") | ||
| && step.run.includes(`--shard=\${{ matrix.shard }}/${windowsShards.length}`))).toBe(true); |
There was a problem hiding this comment.
This still does not ensure that the Windows step executes the test suite: a no-op such as run: echo bun test --isolate tests --shard=${{ matrix.shard }}/4 satisfies both includes checks while running no tests. Since the change is specifically intended to prevent a no-op or unrelated command from passing this hardening test, match the executable command itself—for example, by normalizing the script and requiring an anchored command line—rather than merely requiring both strings in the same run value.
Useful? React with 👍 / 👎.
|
Closing this wrong-base fork PR after validating a corrected |
1 participant
Motivation
Description
tests/ci-workflows.test.tsto require that a Windows step both containsbun test --isolate testsand includes the expected--shard=${{ matrix.shard }}/…argument.Testing
bun run typecheck(bun x tsc --noEmit) — success.node_modules/bun/bin/bun.exe test tests/ci-workflows.test.ts— all tests in that file passed (113 pass, 0 fail).bun test; the run completed but surfaced one unrelated existing failure intests/server-auth.test.ts(expected 401 but received 403).