docs(skill): keep access-key creation out of agent sessions - #373
Conversation
release: promote dev into main for v2.32.1
# Conflicts: # package.json
[WRONG BRANCH] merge dev into main for the v2.33.0 release
Promotes the dev integration line onto main. The resulting tree is byte-identical to origin/dev, including package.json at 2.34.0. The package.json conflict is resolved to dev's side, NOT to main's stale 2.33.0. Earlier promotions (lidge-jun#2553, lidge-jun#2507) kept the target's version so the release bump would land on its own "release: vX.Y.Z" commit. That is no longer legal: this very delta adds tests/release-version-line.test.ts, which fails when the in-tree version sits behind the highest release tag. With v2.34.0-preview.20260827 now published, 2.33.0 orders behind it, so a promotion carrying the stale line turns CI red on every shard that runs the suite. The consequence for the release step is that scripts/release.ts skips the bump (release.ts:568, currentVersion === version), so v2.34.0 gets tagged on this merge commit rather than on a separate release commit. The workflow creates the tag itself after publishing and validates expected-sha against the checked-out commit, so the tag still names exactly the audited tree.
[WRONG BRANCH] promote dev onto main for v2.34.0
[WRONG BRANCH] promote dev onto main for v2.35.0
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
the
documentation
github-actions
Bot
changed the title
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6230c42908
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## Secret-bearing commands | ||
|
|
||
| **Do not run `ocx access key create`.** Its one-time response contains the new plaintext |
There was a problem hiding this comment.
When an agent discovers the advertised ocx api-key create alias, this prohibition does not cover it, and src/cli/dispatch.ts forwards that alias to the same handleAccessCommand(["key", ...]) path that returns the plaintext credential. The new regression test likewise checks only the canonical spelling, so the stated secret boundary remains bypassable; prohibit all access-key creation paths from agent sessions and test both command spellings.
AGENTS.md reference: AGENTS.md:L287-L293
Useful? React with 👍 / 👎.
luvs01
changed the title
|
Closing this personal-fork review path because lidge-jun#3324 fully covers the same access-key session-safety requirement and includes the reviewed alias, API, and rotation fixes. |
2 participants
Motivation
ocx access key create --json, which prints a one-time plaintext data-plane credential that can leak into model transcripts.Description
skills/ocx/SKILL.mdthat explicitly forbids runningocx access key createfrom an agent session and instructs the user to create keys in a separate terminal and only report the new key id.skills/ocx/references/03_recipes.mdto remove the agent-invokableocx access key createstep and to document a user-mediated rotation workflow that only removes the old key after the replacement is configured.tests/skill-ocx.test.tsthat asserts the skill contains the prohibition and that the recipes file does not include an executableocx access key createinvocation.Testing
node_modules/.bin/bun test tests/skill-ocx.test.ts, which passed (12 tests, 0 failures).bun run typecheckand the repositorybun run privacy:scan, both of which completed successfully.bun run testsuite was exercised but encountered unrelated environment/timing failures (lab sandbox / proxy-environment guards and a few timeouts); these failures are external to the documentation-only changes and do not affect the focused regression added here.Codex Task