Skip to content

Enable full FOV output from RGB camera - #422

Closed
VanDavv wants to merge 3 commits into
mainfrom
gen2_full_fov
Closed

Enable full FOV output from RGB camera#422
VanDavv wants to merge 3 commits into
mainfrom
gen2_full_fov

Conversation

@VanDavv

@VanDavv VanDavv commented Jul 13, 2021

Copy link
Copy Markdown

With this PR, the preview from the RGB camera is adjusted to meet the full FOV aspect ratio

image

Łukasz Piłatowski added 3 commits July 12, 2021 15:23
@Luxonis-Brandon

Copy link
Copy Markdown

Yes this is a lot nicer!

image

So a quick question - the 1920x1080 (I presume that's the sensor config) is cropped out of the aspect ratio of the full image sensor, is that right?

@Luxonis-Brandon

Copy link
Copy Markdown

But it looks like the spatial location calculator is being used wrong. Look at the location of the TV monitor in the background.

I think the wrong locations are being used between depth and RGB.

@Luxonis-Brandon

Copy link
Copy Markdown

Here's a video showing it:

https://photos.app.goo.gl/RyohNDddfpEx6MF59

@VanDavv

VanDavv commented Jul 14, 2021

Copy link
Copy Markdown
Author

Yes, I saw that too, and I think that's due to the lack of RGB-Depth alignment. Started to work on it here but had some issues

@Luxonis-Brandon

Copy link
Copy Markdown

So I think it's different than RGB depth alignment. As w/out this PR the distances seem correct.

@Luxonis-Brandon

Copy link
Copy Markdown

Here's a video of what's in main for example:
https://photos.app.goo.gl/nayGAPHxqQWvYzU56

@VanDavv

VanDavv commented Aug 2, 2021

Copy link
Copy Markdown
Author

Full FOV preview was enabled in #433 due to performance requirements

@VanDavv VanDavv closed this Aug 2, 2021
jdavidberger pushed a commit to constructiverealities/depthai that referenced this pull request May 26, 2022
Calib data RGB spec translation fix for some CM3/CM4 boards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants