Don't reuse a connection on redirect if certs match but DNS does not (4.4.x) - #5861
Merged
Merged
Conversation
…(4.4.x) We attempt to minimize connection and reconnection work, but in this case we were overly aggressive about retaining the same connection. In some deployments services will share certificates but not DNS addresses; when redirecting between such services we were incorrectly attempting to reuse the connection. This would have resulted in 404s and other misdirected requests. Closes: #5859
yschimke
approved these changes
Mar 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We attempt to minimize connection and reconnection work, but in this case we
were overly aggressive about retaining the same connection. In some deployments
services will share certificates but not DNS addresses; when redirecting
between such services we were incorrectly attempting to reuse the connection.
This would have resulted in 404s and other misdirected requests.
Closes: #5859