Move gzip() from RequestBody to Request.Builder#8838
Merged
Conversation
On Request.Builder the one function can add the header and apply compression. Otherwise the caller needs to keep those calls in sync. One severe drawback of this approach is the calls to Request.Builder are now ordered. If you call gzip() before you call post(), it'll crash. Worse, if you call post() and then gzip() and then post() again with a different body, it'll silently not compress the new body. I don't love this drawback but I think the mitigations aren't worth the effort.
squarejesse
commented
Jun 4, 2025
| * ``` | ||
| */ | ||
| @JvmStatic | ||
| @ExperimentalOkHttpApi |
Contributor
Author
There was a problem hiding this comment.
Dealing with this annotation is what brought me here
Collaborator
|
Should it be on |
Contributor
Author
|
Yeah, I think it’s analogous to We could live without |
JakeWharton
approved these changes
Jun 4, 2025
yschimke
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Request.Builder the one function can add the header and apply compression. Otherwise the caller needs to keep those calls in sync.
One severe drawback of this approach is the calls to Request.Builder are now ordered. If you call gzip() before you call post(), it'll crash. Worse, if you call post() and then gzip() and then post() again
with a different body, it'll silently not compress the new body. I don't love this drawback but I think the mitigations aren't worth the effort.