Revert "refactor(SSE): move static functions to extensions (#9010)"#9098
Merged
Conversation
Collaborator
Author
|
Idiomatic Kotlin is fine. I like idiomatic Kotlin. But I do not want to deprecate working code. Every time we deprecate an API we’re creating work for other people to do, and I don’t want to give our users more work to do. Our existing APIs support Java language callers, and we care way more about Java language callers than most Kotlin language libraries. If we want to introduce additional APIs (and not replacement APIs), we can do that. But they should probably call through the Java-friendly APIs. |
This reverts commit 09fb9a4.
swankjesse
force-pushed
the
jwilson.1002.revert_event_source
branch
from
October 2, 2025 21:03
6e729a4 to
7132f80
Compare
JakeWharton
approved these changes
Oct 2, 2025
yschimke
approved these changes
Oct 3, 2025
Co-authored-by: Jesse Wilson <jwilson@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 09fb9a4.