Skip to content

Update to AGP 9 - #9264

Merged
yschimke merged 6 commits into
lysine-dev:masterfrom
yschimke:cleanup2
Jan 25, 2026
Merged

Update to AGP 9#9264
yschimke merged 6 commits into
lysine-dev:masterfrom
yschimke:cleanup2

Conversation

@yschimke

@yschimke yschimke commented Jan 25, 2026

Copy link
Copy Markdown
Collaborator

First version with compat workarounds in place.

Will cause some issues running in Intellij, but support coming in Q1. And we are already on 8.13.1 which is not compatible.

First version with compat workarounds in place.
@yschimke

Copy link
Copy Markdown
Collaborator Author

Could not determine the dependencies of task ':native-image-tests:lintReportJvm'.
> Could not create task ':native-image-tests:lintAnalyzeJvmMain'.
   > DefaultTaskContainer#NamedDomainObjectProvider.configure(Action) on task set cannot be executed in the current context.

@yschimke

Copy link
Copy Markdown
Collaborator Author
Could not determine the dependencies of task ':native-image-tests:nativeTestCompile'.
> Could not resolve all dependencies for configuration ':native-image-tests:nativeImageTestClasspath'.
gradle/actions: Writing build results to /home/runner/work/_temp/.gradle-actions/build-results/__run_2-1769338155250.json

[Incubating] Problems report is available at: file:///home/runner/work/okhttp/okhttp/build/reports/problems/problems-report.html
   > Could not create task ':native-image-tests:generateJvmMainLintModel'.
      > DefaultTaskContainer#NamedDomainObjectProvider.configure(Action) on task set cannot be executed in the current context.

@yschimke
yschimke requested a review from swankjesse January 25, 2026 13:21
@yschimke
yschimke marked this pull request as ready for review January 25, 2026 13:21
@yschimke

Copy link
Copy Markdown
Collaborator Author

@swankjesse requesting post review.

We may need to revert if it causes problems, but our gradle build needs some love, and it seems wise to do it against the latest.

@yschimke
yschimke merged commit d75b142 into lysine-dev:master Jan 25, 2026
24 of 27 checks passed
sourceCompatibility(JavaVersion.VERSION_11)
}

kotlinOptions {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to confirm this is just because AGP is now 17+, but the artifacts still work for older android clients...

@swankjesse swankjesse left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread build.gradle.kts
/** Configure publishing and signing for published Java and JavaPlatform subprojects. */
subprojects {
plugins.withId("com.vanniktech.maven.publish.base") {
if (plugins.hasPlugin("com.vanniktech.maven.publish.base")) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? I am under the impression that withId does the same thing, but it’s robust to plugin installation order

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, I should have commented. I'll try reverting this and see why it was breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants