Skip to content

Fix CardputerADV being misdetected as plain Cardputer #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovyan03 merged 1 commit into from
Jul 28, 2026
Merged

Fix CardputerADV being misdetected as plain Cardputer #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/M5GFX.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2432,10 +2432,12 @@ The usage of each pin is as follows.
for (auto &bup : backup_pins2) { bup.restore(); }
if ((result & 3) == 3) {
m5gfx::i2c::i2c_temporary_switcher_t backup_i2c_setting(1, GPIO_NUM_5, GPIO_NUM_6);
result = (m5gfx::i2c::transactionWrite(1, 0x40, nullptr, 0).has_value()
&& m5gfx::i2c::transactionWrite(1, 0x41, nullptr, 0).has_value());
// Keep the probe result out of `result`; the CardputerADV check below
// still needs the G8/G9 bits of the GPIO read.
bool is_vameter = (m5gfx::i2c::transactionWrite(1, 0x40, nullptr, 0).has_value()
&& m5gfx::i2c::transactionWrite(1, 0x41, nullptr, 0).has_value());
backup_i2c_setting.restore();
if (result) {
if (is_vameter) {
board = board_t::board_M5VAMeter;
}
}
Expand Down
Loading