Skip to content

fix: Print domain mapping logs only once per session#598

Merged
Mansi-mParticle merged 2 commits intodevelopmentfrom
fix/SQDSDKS-7554-Irrelevant-Logging
Jul 30, 2025
Merged

fix: Print domain mapping logs only once per session#598
Mansi-mParticle merged 2 commits intodevelopmentfrom
fix/SQDSDKS-7554-Irrelevant-Logging

Conversation

@Mansi-mParticle
Copy link
Copy Markdown
Collaborator

@Mansi-mParticle Mansi-mParticle commented Jul 24, 2025

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Before, NetworkConfigure was called only once in a session. But after adding workspace switching, it started calling NetworkConfigure for every upload. Because of that, the domain mapping logs were printed many times in the same session.
    To fix this, I added a HashSet to make sure the domain mapping logs print only once per session.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with sample app

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@Mansi-mParticle Mansi-mParticle requested a review from a team as a code owner July 24, 2025 21:11
thomson-t
thomson-t previously approved these changes Jul 24, 2025
View reviewed changes
Comment thread android-core/src/main/java/com/mparticle/networking/NetworkOptions.java Outdated
rmi22186
rmi22186 previously approved these changes Jul 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending confirming thomsons comment

@Mansi-mParticle Mansi-mParticle dismissed stale reviews from rmi22186 and thomson-t via b10f277 July 28, 2025 14:56
@Mansi-mParticle Mansi-mParticle requested a review from rmi22186 July 28, 2025 14:56
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 28, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Mansi-mParticle Mansi-mParticle merged commit 0d7e62e into development Jul 30, 2025
15 of 16 checks passed
@Mansi-mParticle Mansi-mParticle deleted the fix/SQDSDKS-7554-Irrelevant-Logging branch July 30, 2025 16:36
mparticle-automation added a commit that referenced this pull request Aug 4, 2025
@mparticle-automation
chore: 5.72.0 (release)
a8c05c0 
## [5.72.0](v5.71.0...v5.72.0) (2025-08-04)

### Features

* Handle hashed email for rokt ([#599](#599)) ([cd5f970](cd5f970))

### Bug Fixes

* Print domain mapping logs only once per session ([#598](#598)) ([0d7e62e](0d7e62e))

### Updates & Maintenance

* Update submodules ([7922018](7922018))
@mparticle-automation
Copy link
Copy Markdown
Collaborator

mparticle-automation commented Aug 4, 2025

🎉 This PR is included in version 5.72.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesnrokt jamesnrokt jamesnrokt left review comments

@rmi22186 rmi22186 rmi22186 approved these changes

@thomson-t thomson-t thomson-t left review comments

@BrandonStalnaker BrandonStalnaker Awaiting requested review from BrandonStalnaker

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mansi-mParticle @mparticle-automation @rmi22186 @thomson-t @jamesnrokt