feat: Handle hashed email for rokt#599
Merged
Mansi-mParticle merged 8 commits intodevelopmentfrom Aug 1, 2025
Merged
Conversation
Mansi-mParticle
requested review from
a team,
BrandonStalnaker and
rmi22186
and removed request for
a team
rmi22186
previously approved these changes
Jul 28, 2025
Member
rmi22186
left a comment
rmi22186
left a comment
There was a problem hiding this comment.
logic looks good. Not sure why there were a lot of mockito updates to the rest of the file, but LGTM overall
rmi22186
reviewed
Jul 29, 2025
rmi22186
reviewed
Jul 29, 2025
Mansi-mParticle
force-pushed
the
feat/SQDSDKS-7556-hashed-email-for-rokt
branch
from
b4f7410 to
c2f7341
Compare
rmi22186
requested changes
Jul 30, 2025
rmi22186
reviewed
Jul 30, 2025
Member
rmi22186
left a comment
rmi22186
left a comment
There was a problem hiding this comment.
Is there a test for this scenario:
If other is a current identity, and the developer passes emailsha256 attribute with a different value from other identity to selectPlacements, log a warning to the user, and call identify with other using the value from emailsha256
|
rmi22186
approved these changes
Jul 31, 2025
Collaborator
|
🎉 This PR is included in version 5.72.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
otherbefore calling the Identity API and invoking the Rokt Kit.Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)