Bump sqlglot from 30.6.0 to 30.7.0#623
Merged
github-actions[bot] merged 2 commits intomasterfrom May 5, 2026
Merged
Conversation
Bumps [sqlglot](https://github.com/tobymao/sqlglot) from 30.6.0 to 30.7.0. - [Commits](tobymao/sqlglot@v30.6.0...v30.7.0) --- updated-dependencies: - dependency-name: sqlglot dependency-version: 30.7.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Owner
|
@collerek - can you take a look at the failing tests? |
…he pollution sqlglot 30.7.0 introduced a per-class TokenizerCore cache keyed only by ``type(self)``. The built core depends on ``self.dialect.IDENTIFIERS_CAN_START_WITH_DIGIT``, but the dialect argument is not part of the cache key. When ``MySQL.Tokenizer()`` is instantiated without an explicit dialect, the resolved dialect falls back to the default and the cached core has ``identifiers_can_start_with_digit=False``. Subsequent ``sqlglot.parse(..., dialect="mysql")`` calls reuse that bad core and fail to parse identifiers starting with digits (e.g. ``0020_big_table`` is split into NUMBER + VAR), producing a degraded ``Table()`` AST. Passing ``dialect="mysql"`` at the two call sites in ``comments.py`` primes the cache with the correct MySQL semantics and keeps the test ``test_get_tables_with_leading_digits`` passing under sqlglot 30.7.0. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps sqlglot from 30.6.0 to 30.7.0.
Commits
693f4edSync w/ integration testsfab6ccffeat(duckdb): Add transpilation support for HEX_ENCODE function (#7591)9bd7e7cchore(publish): Do not build sqlglotc wheels for 3.9 (#7600)43be379Chore: bump sqlglot-mypy to 1.20.0.post6 (#7598)e550d00fix(parser): FROM with JOIN subqueries (#7597)17432c6Fix(generator)!: do not indent newlines within identifiers in pretty mode fix...b573c46Update docstring for annotate types closes #7587327efbfSync w/ integration tests25552eeFeat(optimizer): canonicalize internal query names (#7580)9f169abFix(redshift): supportAPPROXIMATE PERCENTILE_DISCround-trip (#7585)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)