Revert "feat(github): better GitHub app installation tracking"

[whutchinson98]

Reverts #5341

[macro-application]

better github app installation tracking

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c3f1d611-b942-45d7-8548-e4abffbde3b4

📥 Commits

Reviewing files that changed from the base of the PR and between 937b45b and 4e6fa13.

⛔ Files ignored due to path filters (7)

• .sqlx/query-3e0f4214fbae78a344d4586f760c460aabf24e4707e9aa8e7259516f6cecf214.json is excluded by !**/.sqlx/**
• .sqlx/query-43bf593bf69fc1d4f0afdac8738096fc0c1b5ede2c495656d4d7912e55eaaa41.json is excluded by !**/.sqlx/**
• .sqlx/query-cacd042c1649e843312bfeb40093ebc2ae8fb2a14a0bc5841be3d09c1cb8b1a7.json is excluded by !**/.sqlx/**
• Cargo.lock is excluded by !**/*.lock, !**/Cargo.lock
• packages/sdk/generated/storage/index.ts is excluded by !**/generated/**
• packages/sdk/generated/storage/sdk.gen.ts is excluded by !**/generated/**, !**/*.gen.ts
• packages/sdk/generated/storage/types.gen.ts is excluded by !**/generated/**, !**/*.gen.ts

📒 Files selected for processing (26)

• apps/web/src/lib/service-clients/service-storage/openapi.json
• crates/document_storage_service_client/src/github.rs
• crates/document_storage_service_client/src/lib.rs
• crates/github/Cargo.toml
• crates/github/src/domain/models/installation_state.rs
• crates/github/src/domain/models/installation_state/test.rs
• crates/github/src/domain/models/mod.rs
• crates/github/src/domain/models/sync.rs
• crates/github/src/domain/ports/sync.rs
• crates/github/src/domain/service/sync/handle_installation.rs
• crates/github/src/domain/service/sync/mod.rs
• crates/github/src/domain/service/sync/test.rs
• crates/github/src/inbound.rs
• crates/github/src/inbound/github_sync_router/mod.rs
• crates/github/src/inbound/github_sync_router/test.rs
• crates/github/src/outbound/github_sync_client.rs
• crates/github/src/outbound/github_sync_client/test.rs
• crates/github/src/outbound/pg_github_sync_repo.rs
• crates/github/src/outbound/pg_github_sync_repo/test.rs
• packages/sdk/specs/storage.json
• services/authentication_service/src/api/oauth2/github.rs
• services/document_storage_service/src/api/internal/associate_github_installations.rs
• services/document_storage_service/src/api/internal/mod.rs
• services/document_storage_service/src/api/mod.rs
• services/document_storage_service/src/config.rs
• services/document_storage_service/src/main.rs

---

📝 Walkthrough

Summary by CodeRabbit

• New Features

  • GitHub App installations are now automatically associated with the correct account and linked sources.
  • Existing installations can be associated when a GitHub account is connected.
  • Installation cleanup is handled automatically when installations are removed.

• Improvements

  • Simplified GitHub installation redirects no longer require authentication during the redirect process.
  • Updated API documentation to reflect the streamlined installation flow.

Walkthrough

The GitHub installation setup and OAuth state flow were removed. GitHub sync now records installation installers, resolves linked Macro sources, and associates installations during webhook processing or after GitHub account linking. A new internal document storage endpoint and client method support retroactive association. The GitHub router now redirects directly to the sync app. Configuration, dependencies, API specifications, and tests were updated accordingly.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Preview: https://revert-5341-whutchinson98-macr-hbdcgy.preview.macro.com/app (34f8607)