Skip to content

fix(email-service): explicitly declare optional field#568

Merged
whutchinson98 merged 1 commit intomainfrom
evan/fixy
Dec 11, 2025
Merged

fix(email-service): explicitly declare optional field#568
whutchinson98 merged 1 commit intomainfrom
evan/fixy

Conversation

@evanhutnik
Copy link
Copy Markdown
Contributor

Summary

explicitly declare optional field so we don't get errors

Screenshots, GIFs, and Videos

Copy link
Copy Markdown
Contributor

@seanaye seanaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we write a test case for this to avoid future regressions?

EDIT: fine to do as a follow up PR, but we should make a ticket so it doesnt get lost

@evanhutnik
Copy link
Copy Markdown
Contributor Author

Could we write a test case for this to avoid future regressions?

i had to pull over to make this fix, i will later

@whutchinson98 whutchinson98 merged commit 44c16ac into main Dec 11, 2025
35 checks passed
@whutchinson98 whutchinson98 deleted the evan/fixy branch December 11, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants