chore(email-service): Add tests for sql queries#598
Merged
evanhutnik merged 1 commit intomainfrom Dec 12, 2025
Merged
Conversation
whutchinson98
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding tests for queries.
First query is the one I fixed in this PR yesterday.
Second one is query I updated in this PR today. The test cases surfaced some weird behaviour that was happening due to the grouping. I rewrote the query to query on
email_threadsfirst instead ofemail_messageswhich fixed the problems.Screenshots, GIFs, and Videos