feat(email): allow sending actual attachments in emails

[dev-rb]

Summary

This PR adds the ability to send actual normal email attachments instead of macro attachments when sending messages in a thread. The same functionality for email compose will be done in a separate PR since we don't currently have it setup to save drafts of composed messages

Also:

• Updates AttachMenu for emails to use DropdownMenu
• Changes EmailAttachmentPill to not rely on Attachment type
• Adds a plural string util
• Generates types

Screenshots, GIFs, and Videos

[github-actions]

Preview: https://rahul-comms-103-ui-for-sending-ucdwgu.preview.macro.com/app (f625a82)

[claude]

Code Review

Found 2 critical logic errors in createEmailFormState.ts that will cause data loss.

---

Issue 1: Logic Error in removeByFile (line 258)

Location: createEmailFormState.ts:256-259

Problem: The filter logic will incorrectly remove ALL remote attachments when trying to remove a single local attachment.

Current code:

removeByFile: (file: File) => {
  setAttachments((p) =>
    p.filter((a) => a.type === 'local' && a.file \!== file)
  );
},

This filter only keeps attachments that satisfy BOTH:

• a.type === 'local' (is a local attachment) AND
• a.file \!== file (doesn't match the file being removed)

Issue: All remote attachments fail the first condition, so they are all removed.

Suggested fix:

removeByFile: (file: File) => {
  setAttachments((p) =>
    p.filter((a) => a.type \!== 'local' || a.file \!== file)
  );
},

This correctly keeps:

• All remote attachments (since a.type \!== 'local' is true)
• All local attachments except the one being removed

---

Issue 2: Logic Error in removeByID (line 264)

Location: createEmailFormState.ts:261-266

Problem: The filter logic will incorrectly remove ALL local attachments when trying to remove a single remote attachment.

Current code:

removeByID: (attachmentID: string) => {
  setAttachments((p) =>
    p.filter(
      (a) => a.type === 'remote' && a.attachmentID \!== attachmentID
    )
  );
},

This filter only keeps attachments that satisfy BOTH:

• a.type === 'remote' (is a remote attachment) AND
• a.attachmentID \!== attachmentID (doesn't match the ID being removed)

Issue: All local attachments fail the first condition, so they are all removed.

Suggested fix:

removeByID: (attachmentID: string) => {
  setAttachments((p) =>
    p.filter(
      (a) => a.type \!== 'remote' || a.attachmentID \!== attachmentID
    )
  );
},

This correctly keeps:

• All local attachments (since a.type \!== 'remote' is true)
• All remote attachments except the one being removed

---

Both of these bugs would cause unintended data loss when users try to remove attachments from email drafts.

[synoet]

overall looks good