feat(email): creating drafts & sending actual attachments in email compose #995
Merged
feat(email): creating drafts & sending actual attachments in email compose #995
Conversation
…ft collect and save logic
dev-rb
force-pushed
the
rahul/feat-sending-attachments-in-email-compose
branch
2 times, most recently
from
da267dc to
3eaca7d
Compare
…ding-attachments-in-email-compose
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
1 similar comment
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
dev-rb
changed the title
Contributor
im getting infinite spinner tryna upload this docx
|
Contributor
Author
|
If you drag and dropped, it's not going to attach it as an actual attachment so it's trying to add the docx to the markdown. Not sure what's causing the loading issue but it is a different issue. But I think I will switch the drag and drop logic to attach the file as an actual attachment instead of the current behavior EDIT: Added drag and drop as actual attachments |
peterchinman
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a stacked PR built on #993 and #935. This handles adding draft creation and adding actual attachments in the email compose view.
You can use the paperclip button to select files from your computer or drag and drop. This replaces the current/previous functionality of drag and drop where it would place the document in the markdown at a position. Now, all dnd files/folders are added as actual attachments
TODO:
Screenshots, GIFs, and Videos