Sn1 128 utilize entire page for summarization context #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-context Whole page summarization context
dbobrenko
approved these changes
Jul 17, 2024
Collaborator
dbobrenko
left a comment
dbobrenko
left a comment
There was a problem hiding this comment.
LGTM with minor suggestions
dbobrenko
reviewed
Jul 17, 2024
dbobrenko
reviewed
Jul 17, 2024
| else: | ||
| dataset = dataset() | ||
| if task_name == SummarizationTask.name: | ||
| dataset = dataset(selector='all') |
Collaborator
There was a problem hiding this comment.
Suggested change
| dataset = dataset(selector='all') | |
| dataset = dataset(selector="all") |
Should we just modify the default argument of WikiDataset.get for selector="all", to make the code less coupled?
Co-authored-by: Dmytro Bobrenko <17252809+dbobrenko@users.noreply.github.com>
Collaborator
Author
|
Replaced by #306 |
bkb2135
deleted the
SN1-128-Utilize-entire-page-for-summarization-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the entire page for summarization