Add dark mode to venue map - #26
Conversation
af003a2 to
5b5ff73
Compare
Deploying coding-website with
|
| Latest commit: |
5b5ff73
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1693b4b4.coding-website-7wo.pages.dev |
| Branch Preview URL: | https://codex-dark-mode-map.coding-website-7wo.pages.dev |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe venue map now selects Carto tiles from the document theme, updates its tile layer when the theme changes, cleans up the observer, and applies dark-theme Leaflet control, popup, border, hover, and attribution styles. ChangesVenue Map Theme Support
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change adds dark-mode styling to the venue map, and no actionable merge-blocking risk remains. Sequence Diagram(s)sequenceDiagram
participant document
participant MutationObserver
participant VenueMap
participant LeafletTileLayer
document->>MutationObserver: change data-theme
MutationObserver->>VenueMap: notify theme mutation
VenueMap->>LeafletTileLayer: setUrl(theme-specific Carto URL)
VenueMap->>MutationObserver: disconnect on cleanup
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
added dark map in darkmode
Summary by CodeRabbit
New Features
Bug Fixes