Fix Core Text renderer#681
Merged
splhack merged 2 commits intomacvim-dev:masterfrom May 12, 2018
Merged
Conversation
|
This definitely fixes the bug from earlier that I found - however another interesting bug I see is that emoji seem to now be positioned slightly off, which causes a bit of cropping to the emoji: |
Member
Author
|
@amadeus Please tell me unicode codepoints of those emojis. |
|
It actually appears to effect every emoji I've seen? Another example
|
|
In terms of the other characters, the codepoints (in order) are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix display of some unicode composing characters
e.g. A̮︠ (U+0041 032E FE20)
present:
patched:
Fix display of 2-cells emoji
e.g. 💻 (U+1F4BB)
present: the value of
&t_nd(==<C-L>: move cursor right) is appended just after emojipatched:
