docs(update): stop claiming self-update deletes the box image - #277
Merged
Conversation
The deletion was already removed from post-update-refresh (it now reports build-context freshness). This sweeps the messages, help text, comments and docs that still told the user the image gets wiped: - update.ts plan line + --skip-self help now say the image is re-checked and left in place; its fingerprint rebuilds it on the next create only if the build context changed. Adds a plan line for the cloud-base adoption step. - index.ts startup prompt: "re-check the box image" instead of "box image". - install.ts comment: "image re-check" not "image wipe". - architecture.md / development.md / test-plan.md: describe the freshness check + cloud-base adoption; drop the "self-update does the rmi for you". No runtime behaviour change. Claude-Session: https://claude.ai/code/session_011pKPDo9WP1sxwQTQBxHF47
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Backlog item: "self-update shouldn't remove the docker image anymore, since the hash will do that only when needed."
The actual
docker image rmwas already gone frompost-update-refresh.ts(it now reports build-context freshness instead). This PR is the language sweep — every message, help string, comment and doc line that still told the user the box image gets wiped, which was now a lie.Changes
apps/cli/src/commands/update.ts— the printed plan line no longer saysdocker image rm -f <image>; it now reads that the image is re-checked and left in place, and its build-context fingerprint rebuilds it on the next create only if the context changed. Added a plan line for the existing cloud-base adoption step.--skip-selfhelp updated to match ("re-check the image", not "refresh image").apps/cli/src/index.ts— the "agentbox was updated" startup prompt now says "re-check the box image" instead of "box image".apps/cli/src/commands/install.ts— comment "image wipe" → "image re-check".docs/architecture.md,docs/development.md,docs/test-plan.md— describe the freshness check + cloud-base adoption; dropped the "agentbox self-updatedoes thedocker rmifor you" claim.apps/web/content/docs/cli.mdxalready reflected reality ("checked, not deleted") — left as is.No runtime behaviour change to
post-update-refresh.ts(no remaining deletion was found there).Verification
pnpm --filter @madarco/agentbox lint— cleanpnpm --filter @madarco/agentbox typecheck— cleanpnpm --filter @madarco/agentbox test— 1084 passed, 1 skippednode apps/cli/dist/index.js self-update --dry-runThe plan no longer promises an image removal.
node apps/cli/dist/index.js self-update --helphttps://claude.ai/code/session_011pKPDo9WP1sxwQTQBxHF47
Note
Low Risk
String and documentation updates only; no changes to post-update refresh or image handling logic.
Overview
This PR is a language-only sweep: runtime behavior in
post-update-refreshwas already not removingagentbox/box:dev; user-facing strings still claimed a wipe.CLI messaging now says the box image is re-checked and left in place, with rebuild on the next
create/claudeonly when the build-context fingerprint changes. That applies to theself-updatedescription and--skip-selfhelp, the dry-run plan line (replacingdocker image rm -f), the post-version-change confirm inindex.ts, and an install-wizard comment. The dry-run plan also surfaces the existing cloud-base adoption step asbases: adopt any matching cloud base bake….Docs (
architecture.md,development.md,test-plan.md) match: content-addressed context, no “self-update deletes the image for you,” and UPDATE test signals expect re-check not deletion.Reviewed by Cursor Bugbot for commit bc7f54f. Configure here.