Add quick and full demo tenant smoke tests#1991
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds a trusted approval-trigger workflow and rewrites the Demo tenant smoke-test workflow to validate approval context, support quick/full runs, verify results, publish private reports, and complete PR checks. Documentation updates describe configuration, permissions, report handling, and merge-gate behavior. ChangesDemo tenant smoke testing
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Reviewer
participant ApprovalTrigger
participant SmokeWorkflow
participant Maester
participant PrivateReportRelease
participant GitHubChecks
Reviewer->>ApprovalTrigger: submit approved review
ApprovalTrigger->>SmokeWorkflow: trigger workflow_run
SmokeWorkflow->>SmokeWorkflow: validate approval and derive run parameters
SmokeWorkflow->>Maester: run Demo tenant smoke tests
Maester-->>SmokeWorkflow: return test results
SmokeWorkflow->>PrivateReportRelease: publish HTML report
SmokeWorkflow->>GitHubChecks: complete PR smoke check
Possibly related PRs
Suggested labels: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
Deploying maester with
|
| Latest commit: |
a6fa2ba
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eb81bf14.maester.pages.dev |
| Branch Preview URL: | https://codex-demo-tenant-quick-full.maester.pages.dev |
Summary
Demo tenant Invoke-Maester smoke testMT.1068Demo tenant quick smokecheck on the current PR test merge commitmainand on the weekly scheduleSecurity
The review-event workflow has no token permissions, secrets, checkout, or OIDC access. The credentialed
workflow_runworkflow is loaded frommain, never executes PR code or artifacts, and independently verifies the source job, open PR, current head and test merge SHAs, current approval, and reviewer repository permission before creating a check or entering the protectedmaester-smoke-testenvironment.The dedicated Entra app has been updated out of band to declare and consent exactly the 24 default read-only Microsoft Graph application permissions returned by
Get-MtGraphScope. It has no permissions for other resource APIs, no Azure role, no client secret, and no certificate credential. Its federated credential remains scoped torepo:maester365/maester:environment:maester-smoke-test.Validation
actionlintv1.7.12 on both workflowsgit diff --checkGet-MtGraphScope.Tests.ps1: 4 passedRollout
Do not add the new required check before this workflow reaches
main; doing that would deadlock this pull request. After merge, let an approved PR createDemo tenant quick smoke, then add that exact context to active rulesetProtect main(ID 533197). At that point, a failed or absent quick run blocks merging.Draft PR #1990 fixes the existing NotRun warning flood and is recommended before the first full run, but remains a separate change.
Summary by CodeRabbit
New Features
Documentation