[CNS] Implements Grenzo's Rebuttal

[androosss]

Implement Grenzo's Rebuttal

[xenohedron]

custom effect is overimplemented and needs to be fully reworked

[xenohedron]

try using CardTypeAssigner in a custom target class, instead of reimplementing all the target choose code multiple times

[androosss]

I didn't find a way for number of choices to be modular with CardTypeAssigner(like choosing same permanent for artifact and creature) so i made loop to reuse code like it was done in most recent effect like this in [[Mythos of Snapdax]].

[xenohedron]

okay, you fulfilled the literal request, but that's not the point

What I really care about here is that the loop can be trivially analyzed to know that it will always finish. That means using a foreach / iterator. for (Object object : Set objects) basically.

[JayDi85]

It’s special code style for infinite players list. There are some cards with playerList.getNext() and getPrev(). The main logic — stop infinite iterate on get starting player.

[androosss]

Yeah, i tried to find a way to use foreach but only public methods that circular list allows are modifying list. It could be done with selecting index manually with getting index of current player and then incrementing it but that doesn't seem clean to me.

[JayDi85]

It's by design cause there are possible effects that can change players order from left to right, see Aeon Engine.

So after getting copy by game.getState().getPlayersInRange -- you must call getNext and getPrev with game param (so it will cycle in good direction). Also you can use that code to get a static players list with workable index access -- controllerId will have index 0, next player +1, etc

List<UUID> playersList = new ArrayList<>(game.getState().getPlayersInRange(controllerId, game, true));

[JayDi85]

List<UUID> playersList = new ArrayList<>(game.getState().getPlayersInRange(controllerId, game, true));
for (int i = 0; i < playersList.size(); i++) {
  UUID currentPlayer = playersList.get(i);
  UUID nextPlayer = playersList.get(i + 1 < playersList.size() ? i + 1 : 0);
}