Audit filters being declared unnecessarily when a shared static one will suffice #14417
Open
muz wants to merge 12 commits intomagefree:masterfrom
Open
Audit filters being declared unnecessarily when a shared static one will suffice #14417muz wants to merge 12 commits intomagefree:masterfrom
muz wants to merge 12 commits intomagefree:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got called out for this on a couple of PRs in the past.
Took a peek and this is by no means all of them; but there's plenty of instances of new filters being declared where they're not needed. The StaticFilters are there to help prevent the client having to create extra objects across the course of the game - so let's use them where we can.