Refactor creature flip cards to not use private token classes#14569
Open
muz wants to merge 13 commits intomagefree:masterfrom
Open
Refactor creature flip cards to not use private token classes#14569muz wants to merge 13 commits intomagefree:masterfrom
muz wants to merge 13 commits intomagefree:masterfrom
Conversation
muz
force-pushed
the
flip_creaturetoken
branch
from
b61eaf6 to
d8bc8f5
Compare
muz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to #14315
There's a bunch of private token classes that are used for Flip cards which needed refactoring too. This finally gets around to also refactoring all but 2 of the Creature flip cards.
These two remain for now because it's not as straightforward a change as all the ones in this PR are.
Due to how those are implemented, doing it in the same way ends up throwing
Flexible Constructor Bodieswarnings which are only available with source level 25 or above. I'm sure there's a way to get these to not use private token classes, but I can deal with that in a different PR later.Aside from this, this PR being merged then leaves the 5 flip cards where they flip into an Enchantment, so using a CreatureToken is obviously inappropriate here. Again, that can be addressed in a PR of its own.
Slowly but surely, I'll get the backlog of tech debt dealt with to enable that CI test on verifying Token usage 😂