Open
Conversation
theelk801
requested changes
Apr 6, 2026
| if (permanent == null) { | ||
| continue; | ||
| } | ||
| int damage = GetXValue.instance.calculate(game, source, this); |
Contributor
There was a problem hiding this comment.
you can move this outside the loop since it stays the same
| } | ||
| int damage = GetXValue.instance.calculate(game, source, this); | ||
| if (damage > 0) { | ||
| permanent.damage(damage, source.getSourceId(), source, game); |
Contributor
There was a problem hiding this comment.
this method returns the amount of damage dealt so you can use that to determine whether it happened
|
|
||
| DamagedByWatcher watcher = game.getState().getWatcher(DamagedByWatcher.class, source.getSourceId()); | ||
| if (watcher != null && watcher.wasDamaged(permanentId, game)) { | ||
| new MutagenToken().putOntoBattlefield(1, game, source); |
Contributor
There was a problem hiding this comment.
you should count the amount of successful damages and then create that many tokens once
| ShellshockEffect() { | ||
| super(Outcome.Damage); | ||
| staticText = "for each opponent, choose up to one target creature that player controls." | ||
| + " Shellshock deals X damage to each of those creatures." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to #14007