Skip to content

Fatal Fissure needs manual targeting to earthbend#14798

Open
matoro wants to merge 1 commit intomagefree:masterfrom
matoro:fatalfissure
Open

Fatal Fissure needs manual targeting to earthbend#14798
matoro wants to merge 1 commit intomagefree:masterfrom
matoro:fatalfissure

Conversation

@matoro
Copy link
Copy Markdown
Contributor

@matoro matoro commented Apr 22, 2026

Unfortunately, WhenTargetDiesDelayedTriggeredAbility does not support any effects which require a separate target independent of the triggering target. So in order to choose a separate target at trigger time, we have to do it manually in a custom effect.

The only other card I could find with a similar effect is [[Reincarnation]], so this is mostly copied from it.

Fixes #14765

Unfortunately, `WhenTargetDiesDelayedTriggeredAbility` does not support
any effects which require a separate target independent of the
triggering target.  So in order to choose a separate target at trigger
time, we have to do it manually in a custom effect.

The only other card I could find with a similar effect is
[[Reincarnation]], so this is mostly copied from it.

Fixes magefree#14765
@ssk97
Copy link
Copy Markdown
Contributor

ssk97 commented Apr 22, 2026

Wouldn't it be better to add support for targeting? I haven't looked closely, but I'd suspect that WhenTargetDiesDelayedTriggeredAbility is lacking the game.fireReflexiveTriggeredAbility.

@matoro
Copy link
Copy Markdown
Contributor Author

matoro commented Apr 22, 2026

Wouldn't it be better to add support for targeting? I haven't looked closely, but I'd suspect that WhenTargetDiesDelayedTriggeredAbility is lacking the game.fireReflexiveTriggeredAbility.

If I'm understanding, that would be simply moving this code from the card into the ability, which I have been not been doing unless there are 2 or more cards that support the use case. Would you prefer that?

@ssk97
Copy link
Copy Markdown
Contributor

ssk97 commented Apr 22, 2026

First of all, closer review suggests to me that your code is wrong. You have target selection happening as the trigger resolves, it needs to happen when the trigger is placed on the stack.

If I'm understanding, that would be simply moving this code from the card into the ability, which I have been not been doing unless there are 2 or more cards that support the use case. Would you prefer that?

It'd be more complex than that. It needs to be made generic, similar to DoWhenCostPaid.

@matoro
Copy link
Copy Markdown
Contributor Author

matoro commented Apr 28, 2026

First of all, closer review suggests to me that your code is wrong. You have target selection happening as the trigger resolves, it needs to happen when the trigger is placed on the stack.

If I'm understanding, that would be simply moving this code from the card into the ability, which I have been not been doing unless there are 2 or more cards that support the use case. Would you prefer that?

It'd be more complex than that. It needs to be made generic, similar to DoWhenCostPaid.

I've been trying to follow how this would work for quite a while now but I'm not sure what you're getting at. DoWhenCostPaid is an effect while a ReflexiveTriggeredAbility is an ability, and WhenTargetDiesDelayedTriggeredAbility takes an effect. Could you clarify a bit more about what kind of call chain you are talking about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fatal Fissure Doesn't Earthbend

2 participants