Corrects a bug where mdfc zone changes failed to return to command zone#14992
Open
oscscull wants to merge 7 commits into
Open
Corrects a bug where mdfc zone changes failed to return to command zone#14992oscscull wants to merge 7 commits into
oscscull wants to merge 7 commits into
Conversation
oscscull
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #14991
Original example was fairly complex, so there were a few candidate problems I looked at.
Replication was: MDFC commanders' half ids on the battlefield are different from their commander ids. As we currently don't check this, that means that replacement effects can miss them and they won't get returned to the command zone when they should.
This PR corrects that. I'd imagine it will prevent some other potential bugs with MDFC commanders.