Auditory indicator when user action is required in FeedbackPanel#6558
Closed
dperegolise wants to merge 1 commit intomagefree:masterfrom
Closed
Auditory indicator when user action is required in FeedbackPanel#6558dperegolise wants to merge 1 commit intomagefree:masterfrom
dperegolise wants to merge 1 commit intomagefree:masterfrom
Conversation
This was referenced May 19, 2020
Contributor
|
Merged in PR #6755 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix the problem where users are constantly waiting on one another to interact with the feedback panel, because they tend to tab-out or look at another monitor during other player's turns, and there is currently no auditory indication that the game is waiting on feedback from the active player.
The sound will only play if the feedback panel switches modes from INFORM > NON-INFORM, and if the user has not interacted with the game for the last 2 seconds. This prevents spamming of the indicator sound. The 2 seconds window is implemented using timestamp comparison, not timers; so it should be pretty lightweight.
In casual testing, this seems to work really well.
FeedbackNeeded.wav is from here: https://timbeek.itch.io/casual-soundfx-pack (Pickup Soft) under cc license (https://creativecommons.org/licenses/by/4.0/). The sound file has been modified to match other sound files with 352.8kb/s bitrate, 22.05 kHz sample rate, 1 channel, 90.4kb in size.
The new sound is called 'feedbackNeeded' and it is grouped under AudioGroup.GameSounds.