[DON'T MERGE] Linux startup scripts update (fixes #6805)#6822
Open
Dragas wants to merge 2 commits intomagefree:masterfrom
Open
[DON'T MERGE] Linux startup scripts update (fixes #6805)#6822Dragas wants to merge 2 commits intomagefree:masterfrom
Dragas wants to merge 2 commits intomagefree:masterfrom
Conversation
JayDi85
requested changes
Jul 10, 2020
JayDi85
requested changes
Jul 10, 2020
* fixes an issue where scripts would start in debug mode * fixes an issue where client script would not have project version * fixes an issue where start mage script would incorrectly point to two other scripts
JayDi85
changed the title
fearphage
reviewed
Aug 15, 2020
| script_dir="$(dirname -- $script_dir)" | ||
| cd $script_dir | ||
|
|
||
| java -Xms256m -Xmx2g -XX:MaxPermSize=256m -XX:+UseConcMarkSweepGC -XX:+CMSClassUnloadingEnabled -jar "${script_dir}/lib/mage-client-${project.version}.jar" |
Contributor
There was a problem hiding this comment.
Would make this a bit more readable and make future diffs smaller if you broke these out into lines.
Suggested change
| java -Xms256m -Xmx2g -XX:MaxPermSize=256m -XX:+UseConcMarkSweepGC -XX:+CMSClassUnloadingEnabled -jar "${script_dir}/lib/mage-client-${project.version}.jar" | |
| java \ | |
| -Xms256m \ | |
| -Xmx2g \ | |
| -XX:MaxPermSize=256m \ | |
| -XX:+UseConcMarkSweepGC \ | |
| -XX:+CMSClassUnloadingEnabled \ | |
| -jar "${script_dir}/lib/mage-client-${project.version}.jar" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also includes proper line endings