MAGECLOUD-1619: [Spike] Sanitize Sensitive Information from Infrastructure Logs #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NadiyaS
reviewed
Mar 29, 2018
| ['message' => 'some message'] | ||
| ], | ||
| [ | ||
| ['message' => 'some message with admin password --admin-password=\'Ks81bUSl13Osd\''], |
There was a problem hiding this comment.
add cases when:
- password has '
- text contains other symbols after password
- password value is --db-password='a' (may be combined with the first point)
- txt contain both type of passwords
NadiyaS
reviewed
Mar 29, 2018
| * @var array | ||
| */ | ||
| private $replacements = [ | ||
| '/--admin-password=\'.*?\'/i' => '--admin-password=\'******\'', |
There was a problem hiding this comment.
you may unify and check every password=\'...\'
NadiyaS
approved these changes
Apr 3, 2018
BaDos
suggested changes
Apr 3, 2018
|
QA approved |
BaDos
approved these changes
Apr 6, 2018
andriyShevtsov
added
Progress: accept
YPyltiai
added
Release: 2002.0.11
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Oct 8, 2025
MCLOUD-14104: Cloud tools October Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanitize Sensitive Information from Logs
Description
Fixed Issues (if relevant)
https://magento2.atlassian.net/browse/MAGECLOUD-1619
Zephyr Tests
https://jira.corp.magento.com/browse/MAGETWO-89800
Contribution checklist