MAGECLOUD-3866: Warm up functionality does not work if no store with 'default' code #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
4 tasks
| public function __construct( | ||
| StoreManagerInterface $storeManager | ||
| ) { | ||
| parent::__construct(); |
Member
There was a problem hiding this comment.
Parent constructor should go after properties assignment after a newline
Contributor
Author
There was a problem hiding this comment.
Why? Is this Magento code standard?
Member
There was a problem hiding this comment.
Most Magento code use parent after
Contributor
Author
There was a problem hiding this comment.
Not most, we don't have such rule.
| protected function configure() | ||
| { | ||
| $this->setName('config:show:default-url') | ||
| ->setDescription( |
| $output->write($store->getBaseUrl(UrlInterface::URL_TYPE_LINK, $store->isUrlSecure())); | ||
|
|
||
| return Cli::RETURN_SUCCESS; | ||
| } catch (\Exception $e) { |
Member
There was a problem hiding this comment.
This try-catch does not provide any value, can be removed
shiftedreality
suggested changes
Jul 9, 2019
| /** | ||
| * @param StoreManagerInterface $storeManager | ||
| */ | ||
| public function __construct( |
NadiyaS
approved these changes
Jul 9, 2019
shiftedreality
approved these changes
Jul 17, 2019
YPyltiai
added
Progress: approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://magento2.atlassian.net/browse/MAGECLOUD-3866
Related PR
magento/ece-tools#560