-
Notifications
You must be signed in to change notification settings - Fork 16
MAGECLOUD-3866: Warm up functionality does not work if no store with 'default' code #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
9e9c15b
MAGECLOUD-3866: Warm up functionality does not work if no store with …
oshmyheliuk c452fba
MAGECLOUD-3866: Warm up functionality does not work if no store with …
oshmyheliuk eb25d5e
MAGECLOUD-3866: Warm up functionality does not work if no store with …
oshmyheliuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| <?php | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| namespace Magento\CloudComponents\Console\Command; | ||
|
|
||
| use Magento\Framework\Console\Cli; | ||
| use Magento\Framework\UrlInterface; | ||
| use Magento\Store\Model\Store; | ||
| use Magento\Store\Model\StoreManagerInterface; | ||
| use Symfony\Component\Console\Command\Command; | ||
| use Symfony\Component\Console\Input\InputInterface; | ||
| use Symfony\Component\Console\Output\OutputInterface; | ||
|
|
||
| /** | ||
| * Command for getting url for default store of default website. | ||
| */ | ||
| class ConfigShowDefaultUrlCommand extends Command | ||
| { | ||
| /** | ||
| * @var StoreManagerInterface | ||
| */ | ||
| private $storeManager; | ||
|
|
||
| /** | ||
| * @param StoreManagerInterface $storeManager | ||
| */ | ||
| public function __construct(StoreManagerInterface $storeManager) | ||
| { | ||
| parent::__construct(); | ||
| $this->storeManager = $storeManager; | ||
| } | ||
|
|
||
| /** | ||
| * @inheritdoc | ||
| */ | ||
| protected function configure() | ||
| { | ||
| $this->setName('config:show:default-url') | ||
| ->setDescription('Shows base url for default store of default website'); | ||
|
|
||
| parent::configure(); | ||
| } | ||
|
|
||
| /** | ||
| * Returns base url for default store of default website | ||
| * | ||
| * {@inheritdoc} | ||
| */ | ||
| protected function execute(InputInterface $input, OutputInterface $output) | ||
| { | ||
| /** @var Store $store */ | ||
| $store = $this->storeManager->getDefaultStoreView(); | ||
| $output->write($store->getBaseUrl(UrlInterface::URL_TYPE_LINK, $store->isUrlSecure())); | ||
|
|
||
| return Cli::RETURN_SUCCESS; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parent constructor should go after properties assignment after a newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? Is this Magento code standard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most Magento code use parent after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not most, we don't have such rule.