Added Listener logic to package unintsall #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bibumathew
commented
Oct 31, 2014
bibumathew
commented
- Added Logic to remove the left over module name after composer package uninstall
- Updated logic for magento default root directory
- Removed updateJsonExtra call when magento default root directory is used
Member
|
you have mixed a second commit into this pull request. You can fix this by creating a new branch(for example "patch-1"), change the used branch in your pull request, and then ensure, to only have commits in this branch, you want to have. |
mage2-dev
added a commit
that referenced
this pull request
Oct 31, 2014
Added Listener logic to package unintsall
okorshenko
pushed a commit
that referenced
this pull request
Jan 26, 2016
MAGETWO-44318: [Sample Data] Video Trailers can not be loaded
convenient
referenced
this pull request
in convenient/magento-composer-installer
Oct 16, 2020
We had a project fail to composer install with the following error ``` PHP Warning: Uncaught Exception: Warning: require(/var/www/vhosts/example.com/staging/releases/1602858012/setup/config/application.config.php): failed to open stream: No such file or directory in /var/www/vhosts/example.com/staging/releases/1602858012/vendor/magento/framework/Console/Cli.php on line 78 in /var/www/vhosts/example.com/staging/releases/1602858012/vendor/magento/framework/App/ErrorHandler.php:61 Stack trace: #0 /var/www/vhosts/example.com/staging/releases/1602858012/vendor/magento/framework/Console/Cli.php(78): Magento\Framework\App\ErrorHandler->handler(2, 'require(/var/ww...', '/var/www/vhosts...', 78, Array) #1 /var/www/vhosts/example.com/staging/releases/1602858012/vendor/magento/framework/Console/Cli.php(78): require() magento#2 /var/www/vhosts/example.com/staging/releases/1602858012/bin/magento(22): Magento\Framework\Console\Cli->__construct('Magento CLI') magento#3 {main} thrown in /var/www/vhosts/example.com/staging/releases/1602858012/vendor/magento/framework/App/ErrorHandler.php on line 61 ``` When debugging i could see that a lot of the files from `magento/magento2-base` had not been copied over. I can see an error produced when running with `-vvv` ``` start magento deploy via deployManager start magento deploy for magento/magento2-base mkdir(): File exists start magento deploy for magento/magento2-base mkdir(): File exists start magento deploy for magento/magento2-ee-base jump over deployLibraries as no Magento libraryPath is set ``` I debugged and the issue was that previously on our NFS we had no `pub/media/import` but now we have had one created. Now when magento tried to `composer install` it was trying to copy over https://github.com/magento/magento2/blob/2.4-develop/pub/media/import/.htaccess, it faced this `File exists` error and stopped copying over the remainder of the files silently. I think `composer install` should fail loud and early in these scenarios, removing the error handling entirely allows the exception to bubble up. Any feedback appreciated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.